818079 - Tab menu overlaps URL bar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (12/04) - Screenshot

This must be a recent regression (12/03-12/04). See screenshot.

--
Nightly (12/04)
Samsung Galaxy Nexus (Android 4.1.2)

Comment 1

[Lucas Rocha (:lucasr)]

Probably caused by bug 709433. Steps to reproduce?

Comment 2

[Lucas Rocha (:lucasr)]

This is probably the same as bug 817526. Closing as dup.

Comment 3

[Aaron Train [:aaronmt]]

This is still not fixed (sorry for the delay, noticed via Kats dupe today).

Steps to reproduce in Kats's bug.

Comment 5

[Andreea Pod]

The regression window for this issue:

good build: 03.12.2012  
bad build:  04.12.2012 

possible pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=253009438c5b&tochange=6fa6e55a93b2

Comment 6

[Aaron Train [:aaronmt]]

Yep, was the animation bug 709433

Comment 7

[Kevin Brosnan [Ex-Mozilla]]

Firefox 19 is unaffected. LucasR we have a very short period of time to take a fix for this. Would it be possible to back out bug 709433 if we are unsure of the fix here?

Comment 8

[Lucas Rocha (:lucasr)]

What are the steps to reproduce?

Comment 9

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to Lucas Rocha (:lucasr) from comment #8)
> What are the steps to reproduce?

Looks like Kats has STR in bug 830356 (a dupe of this bug)

Comment 10

[Kevin Brosnan [Ex-Mozilla]]

Double tap in the address bar from any page.

Comment 11

[Lucas Rocha (:lucasr)]

(In reply to Kevin Brosnan [:kbrosnan] from comment #10)
> Double tap in the address bar from any page.

Investigating.

Comment 13

[Lucas Rocha (:lucasr)]

Attachment: Don't allow entering awesomescreen while animating

Because the animation logic relies on updating the layout of the toolbar before and after the actual animation, there's no simple way to allow "reversing" the animation while it's running.

We might be able to do reverse the animation properly once we simplify the animation code as part of bug 848719. But that's likely a more involved patch.

Comment 14

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 724513 [details] [diff] [review]
Don't allow entering awesomescreen while animating

Hmm, I assumed there would be less places to set the mAnimatingEntry state

Comment 15

[Lucas Rocha (:lucasr)]

(In reply to Mark Finkle (:mfinkle) from comment #14)
> Comment on attachment 724513 [details] [diff] [review]
> Don't allow entering awesomescreen while animating
> 
> Hmm, I assumed there would be less places to set the mAnimatingEntry state

mAnimatingEntry needs to be set on the animations to/from awesome screen. And when we (re-)init the toolbar.

Comment 16

[Lucas Rocha (:lucasr)]

Pushed: https://hg.mozilla.org/integration/mozilla-inbound/rev/b65eb98101d5

Comment 17

[Lucas Rocha (:lucasr)]

Comment on attachment 724513 [details] [diff] [review]
Don't allow entering awesomescreen while animating

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 709433
User impact if declined: Broken toolbar layout on certain situations
Testing completed (on m-c, etc.): Local testing, waiting for it to land in m-c. Request approval early given the urgency for the beta release.
Risk to taking this patch (and alternatives if risky): Very low, just avoiding triggering the toolbar animation while it's already running.
String or UUID changes made by this patch: n/a

Comment 18

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b65eb98101d5

Comment 19

[bhavana bajaj [:bajaj]]

Comment on attachment 724513 [details] [diff] [review]
Don't allow entering awesomescreen while animating

low risk uplift for a FX20 regression.

Adding qawanted/verifyme to help with verification here.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c930e279f86d

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f44933ff448f